Use poly-cool as the root finder in bezier-rs #3031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jneem
commented
Aug 8, 2025
| @@ -13,9 +13,13 @@ homepage = "https://github.com/GraphiteEditor/Graphite/tree/master/libraries/bez | |||
| repository = "https://github.com/GraphiteEditor/Graphite/tree/master/libraries/bezier-rs" | |||
| documentation = "https://graphite.rs/libraries/bezier-rs/" | |||
|
|
|||
| [features] | |||
| std = ["glam/std"] | |||
There was a problem hiding this comment.
I needed this to run just the bezier-rs tests (with cargo test -p bezier-rs --features=std), because without it there were lots of undefined references to math functions.
jneem
commented
Aug 8, 2025
| @@ -354,7 +354,8 @@ mod tests { | |||
| assert_eq!(bezier1.project(DVec2::new(100., 100.)), 1.); | |||
|
|
|||
| let bezier2 = Bezier::from_quadratic_coordinates(0., 0., 0., 100., 100., 100.); | |||
| assert_eq!(bezier2.project(DVec2::new(100., 0.)), 0.); | |||
| assert_eq!(bezier2.project(DVec2::new(99.99, 0.)), 0.); | |||
There was a problem hiding this comment.
I had to change this test slightly, because the old point had two nearest points (at t=0 and t=1), and the new root-finder was flagging t=0.999999999 as the minimizer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes symmetrical_basis, which was publicly exported, and so it's a breaking change.
The big caveat here is that poly-cool is not thoroughly tested. I plan to do that next, though, and I think any issues should be fixable without breaking semver compatibility.